|
Nicolas Pastorino
Member since:
09 January 2008
Posts: 53
|
Tuesday 13 September 2011 10:33:09 am
Good one Serhey, simple and useful.
A few remarks that might help, after a quick test-drive :
* Place the sql folder at the root of the extension, as done here :
https://github.com/ezsystems/ezfl.../ezflow_extension/ezextension/ezflow
* When editing the attribute definition at the content class level, i'd find slightly more usable to have the "Update" and "Remove" buttons floating on the left rather than on the right.
Cheers and keep-up contributing !
|
|
|
Serhey Dolgushev
Member since:
14 January 2009
Posts: 14
|
Wednesday 14 September 2011 9:06:38 am
|
|
|
Nicolas Pastorino
Member since:
09 January 2008
Posts: 53
|
Wednesday 14 September 2011 11:47:30 am
Good !
The homepage installation instructions still mention, though :
Execute extension/nxc_string/docs/sql/mysql.sql
Minor update required ;)
|
|
|
Geoff Bentley
Member since:
09 January 2008
Posts: 35
|
Friday 16 September 2011 12:26:10 am
Great extension! The SQL for the table definition seems to be missing, as does the doc folder. It would be possible to store limitations in data_text5 without the need for an extra table, but that's a design choice.
|
|
|
Serhey Dolgushev
Member since:
14 January 2009
Posts: 14
|
Friday 16 September 2011 8:16:16 am
Sorry, SQL file have been moved to
extension/nxc_string/sql/mysql.sql
I`ve updated the project description.
I thought about storing limitations in the some data_text attribute (serialized or XML). But in this case the source code will be more complicated. So i shoosed to use persistent objects :)
|
|
|
kracker
Member since:
09 January 2008
Posts: 33
|
Sunday 18 September 2011 2:22:43 am
Serhey,
You should watch your commit actions more closely..
Upon further examination you have *only* deleted the sql and not moved it at all.
Re: http://websvn.projects.ez.no/wsvn/nxc_string/?op=revision&rev=2
If anyone actually looked at the current svn there is no sql directory at all: http://svn.projects.ez.no/nxc_string/
I also think you should seriously reconsider storing things in a separate table.
I think it would be much improved to remove this requirement. *No matter what*
I remember making certified extensions for eZ Publish certified platform and this was discouraged as much as possible.
Cheers,
//kracker
THEME: Sole and the Skyrider Band : Hello Cruel World : Napolean ...
|
|
|
Serhey Dolgushev
Member since:
14 January 2009
Posts: 14
|
Sunday 18 September 2011 9:50:59 pm
Sorry, it was my bad. I`ve added mysql file to svn and archive.
|
|
|
kracker
Member since:
09 January 2008
Posts: 33
|
Sunday 18 September 2011 10:52:57 pm
|
|
|
Nicolas Pastorino
Member since:
09 January 2008
Posts: 53
|
Monday 19 September 2011 11:02:46 am
Thanks Serhey,
Indeed, as kracker says, a minor glitch remains concerning the directory structure. Today we have :
nxc_string/mysql/mysql.sql
while the more common structure is (preparing for support of other DBMSes) :
nxc_string/sql/mysql/mysql.sql
Cheers and keep-up !
|
|
|
Serhey Dolgushev
Member since:
14 January 2009
Posts: 14
|
Tuesday 20 September 2011 6:41:51 pm
Thenks, Nicolas for explanations.
Sql moved to
{code}
sql/mysql/mysql.sql
{/code}
|
|
|
Nicolas Pastorino
Member since:
09 January 2008
Posts: 53
|
Wednesday 21 September 2011 4:08:43 pm
Good !
|
|
