Path

ez projects / ezkeyword_autocomplete / forum / general / [ez 4.4] bug with "autocomp... / re: [ez 4.4] bug with "auto...


[eZ 4.4] Bug with "AutocompleteKeywordsPerContentClass"

You need to be logged in to post messages in the forums. New users may register here.

Gilles Ballini

Member since:
07 August 2008

Posts: 3

Tuesday 14 December 2010 11:31:38 am

Hi.
In eZ 4.4 (didn't test with older version), it seems that the directive "AutocompleteKeywordsPerContentClass" doesn't work :

Even when it is set to 'enabled', the autocomplete functionnality doesn't filter to current class.


I corrected the bug with the following patch :




Index: design/standard/templates/content/datatype/edit/ezkeyword.tpl


===================================================================


--- design/standard/templates/content/datatype/edit/ezkeyword.tpl       (.../vendor/current)    (rĂ©vision 10)


+++ design/standard/templates/content/datatype/edit/ezkeyword.tpl       (.../trunk)     (rĂ©vision 10)


@@ -18,11 +18,11 @@


 </div>


 

 <script type="text/javascript">


-{def $max_autocomplete_results = ezini( 'eZKeywordSettings', 'MaxAutocompleteResults', 'datatype.ini',, true() )


+{def $max_autocomplete_results = ezini( 'eZKeywordSettings', 'MaxAutocompleteResults', 'datatype.ini' )


         $autocomplete_per_content_class = false()}


 

 

-{if eq( ezini( 'eZKeywordSettings', 'AutocompleteKeywordsPerContentClass', 'datatype.ini',, true() ), 'enabled' )}


+{if eq( ezini( 'eZKeywordSettings', 'AutocompleteKeywordsPerContentClass', 'datatype.ini'), 'enabled' )}


        {set $autocomplete_per_content_class = true()}


        {def $content_class_id = $attribute.object.contentclass_id}


 {else}


Up

Nicolas Pastorino

Member since:
09 January 2008

Posts: 53

Wednesday 15 December 2010 12:42:04 pm

Hi Gilles, and thanks for this feedback !

Would you like to become member of the project and push this patch in the trunk directly ?
You can do so by clicking the "Register" button there : http://projects.ez.no/ezkeyword_autocomplete/team/members

Let me know,
Cheers,

--
Nicolas Pastorino
VP Community - eZ Systems
Member of the Community Project Board

eZ Publish Community on twitter: http://twitter.com/ezcommunity/

t : http://twitter.com/jeanvoye
G+ : http://plus.tl/jeanvoye

Up

Gilles Ballini

Member since:
07 August 2008

Posts: 3

Thursday 16 December 2010 3:47:40 pm

Hi Nicolas,

Thanks for your answer.

I submitted the membership registration on the project.

Cheers,

--
Gilles
Up

Nicolas Pastorino

Member since:
09 January 2008

Posts: 53

Friday 17 December 2010 10:58:17 am

And i approved it.
Welcome aboard Gilles !

--
Nicolas Pastorino
VP Community - eZ Systems
Member of the Community Project Board

eZ Publish Community on twitter: http://twitter.com/ezcommunity/

t : http://twitter.com/jeanvoye
G+ : http://plus.tl/jeanvoye

Up

Gilles Ballini

Member since:
07 August 2008

Posts: 3

Friday 17 December 2010 11:05:17 am

OK, thanks.

I committed the patch.
Up

Nicolas Pastorino

Member since:
09 January 2008

Posts: 53

Monday 20 December 2010 10:08:05 am

Thanks !

Should you be willing to give a deeper face-lift to this extension, just raise a hand and let's start together on this. It is a quite useful extension, but now dates a bit.

Cheers,

--
Nicolas Pastorino
VP Community - eZ Systems
Member of the Community Project Board

eZ Publish Community on twitter: http://twitter.com/ezcommunity/

t : http://twitter.com/jeanvoye
G+ : http://plus.tl/jeanvoye

Up

You need to be logged in to post messages in the forums. New users may register here.