Path

ez projects / admin2pp / forum / general / this extension disables the... / re: this extension disables...


this extension disables the fix commited in eZP 2011.6

You need to be logged in to post messages in the forums. New users may register here.

Marko Žmak

Member since:
09 January 2008

Posts: 52

Wednesday 29 June 2011 6:02:13 pm

Since this extension includes yui_menu.css, it disables the quickfix made for the create menu in this commit:

https://github.com/ezsystems/ezpu...b8a8e0f9c6462bcbdcc184e70a65ffc1e479

Any chances to fix it?

--
Nothing is impossible. Not if you can imagine it!

Hubert Farnsworth

Up

Damien Pobel

Member since:
09 January 2008

Posts: 40

Wednesday 29 June 2011 8:06:07 pm

HI Marko,

Thanks for the report. (We definitively need of the bug tracker per project!)

I know admin2++ has some issues with the latest eZ Publish versions... I'm currently in a general movement to update my extensions to make them fully compatible with the latest eZ Publish versions. I released eZ Class Lists 1.2 some weeks ago, I'm working hard on autostatus (I hope to release it before the next week) and admin2pp is the next one on my TODO list...

In the mean time, you can also apply to be member of the project and fix it yourself (I think it's just a matter of synchronizing the CSS in admin2++ with the default one).

Cheers

Damien
Planet eZ Publish.fr : http://www.planet-ezpublish.fr
Certification : http://auth.ez.no/certification/verify/372448
Publications about eZ Publish : http://pwet.fr/tags/keywords/weblog/ez_publish

Up

Marko Žmak

Member since:
09 January 2008

Posts: 52

Thursday 30 June 2011 12:09:19 am

Ok, did it.

--
Nothing is impossible. Not if you can imagine it!

Hubert Farnsworth

Up

Marko Žmak

Member since:
09 January 2008

Posts: 52

Thursday 30 June 2011 12:42:31 pm

Why is yui_menu.css even included in admin2pp? Couldn't we just remove it and let it use the default one from the admin2?

--
Nothing is impossible. Not if you can imagine it!

Hubert Farnsworth

Up

Damien Pobel

Member since:
09 January 2008

Posts: 40

Monday 18 July 2011 12:28:47 pm

Hi Marko,

I fixed this issue and some others with the last versions of eZ Publish.

The reason to embed yui_menu.css is because the version from admin2pp brings some performance improvements (sprites, remove useless parth, ...)

Cheers

Damien
Planet eZ Publish.fr : http://www.planet-ezpublish.fr
Certification : http://auth.ez.no/certification/verify/372448
Publications about eZ Publish : http://pwet.fr/tags/keywords/weblog/ez_publish

Up

Marko Žmak

Member since:
09 January 2008

Posts: 52

Monday 18 July 2011 12:55:40 pm

If it improves performance, then why not push it in the admin2?

I mean, using and maintaining two different versions of the same file is pretty much nonoptimal...

--
Nothing is impossible. Not if you can imagine it!

Hubert Farnsworth

Up

Damien Pobel

Member since:
09 January 2008

Posts: 40

Monday 18 July 2011 2:12:16 pm

this is more or less the case of a lot of files in the extension (override with some minor changes) because I started this extension before being an eZ Systems employee and before the ability to easily provide contributions to eZ via github.

Btw, some of the changes made in earlier version of admin2pp had been reintegrated in eZ and like the icons-sprite.png use in this style sheet.

Cheers

Damien
Planet eZ Publish.fr : http://www.planet-ezpublish.fr
Certification : http://auth.ez.no/certification/verify/372448
Publications about eZ Publish : http://pwet.fr/tags/keywords/weblog/ez_publish

Up

You need to be logged in to post messages in the forums. New users may register here.